test: add integration test for instrumented Firecracker binary #5497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5497 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 269 269
Lines 27723 27723
=======================================
Hits 22965 22965
Misses 4758 4758
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kalyazin
reviewed
Nov 4, 2025
tests/integration_tests/functional/test_instrumented_firecracker.py
Outdated
Show resolved
Hide resolved
tests/integration_tests/functional/test_instrumented_firecracker.py
Outdated
Show resolved
Hide resolved
tests/integration_tests/functional/test_instrumented_firecracker.py
Outdated
Show resolved
Hide resolved
tests/integration_tests/functional/test_instrumented_firecracker.py
Outdated
Show resolved
Hide resolved
tests/integration_tests/functional/test_instrumented_firecracker.py
Outdated
Show resolved
Hide resolved
tests/integration_tests/functional/test_instrumented_firecracker.py
Outdated
Show resolved
Hide resolved
DontPanicO
force-pushed
the
test_instrumented_binary
branch
2 times, most recently
from
7aca9f2 to
c075816
Compare
kalyazin
reviewed
Nov 5, 2025
tests/integration_tests/functional/test_instrumented_firecracker.py
Outdated
Show resolved
Hide resolved
tests/integration_tests/functional/test_instrumented_firecracker.py
Outdated
Show resolved
Hide resolved
tests/integration_tests/functional/test_instrumented_firecracker.py
Outdated
Show resolved
Hide resolved
tests/integration_tests/functional/test_instrumented_firecracker.py
Outdated
Show resolved
Hide resolved
DontPanicO
force-pushed
the
test_instrumented_binary
branch
from
c075816 to
0f0e9e7
Compare
Adds a new integration test that verifies Firecracker can be built and run with `log_instrument` tracing instrumentation\ enabled. Signed-off-by: DontPanicO <[email protected]>
DontPanicO
force-pushed
the
test_instrumented_binary
branch
from
0f0e9e7 to
4b40a80
Compare
kalyazin
approved these changes
Nov 7, 2025
Contributor
kalyazin
left a comment
kalyazin
left a comment
There was a problem hiding this comment.
Looks good to me!
Let me find someone else to have another look.
kalyazin
added
the
Status: Awaiting review
JackThomson2
approved these changes
Nov 7, 2025
Contributor
|
@DontPanicO thanks again for your contribution! |
Contributor
Author
|
@kalyazin Thanks for the guidance, looking forward to contributing more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a new integration test that verifies Firecracker can be built and run with
log_instrumenttracing instrumentation enabled.Reason
Fixes #4215
As discussed in #4215 (comment) the goal is to validate Firecracker when instrumented specifically with the
log-instrumentcrate from the current workspace, rather than any generic tracing tool.This implementation takes inspiration from #5256, adapting it to work with
log-instrument.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.